Skip to content

Add 2026-06-15-preview API version for Microsoft.KubernetesConfiguration to add KubernetesResources and UpgradeAssessments#43606

Closed
bgriddaluru wants to merge 52 commits into
Azure:mainfrom
bgriddaluru:main
Closed

Add 2026-06-15-preview API version for Microsoft.KubernetesConfiguration to add KubernetesResources and UpgradeAssessments#43606
bgriddaluru wants to merge 52 commits into
Azure:mainfrom
bgriddaluru:main

Conversation

@bgriddaluru

@bgriddaluru bgriddaluru commented May 29, 2026

Copy link
Copy Markdown
Member

Add 2026-06-15-preview API version for Microsoft.KubernetesConfiguration to add KubernetesResources and UpgradeAssessments

@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMModelingReviewRequired label. This means it is introducing a new Resource Provider namespace or a new resource type. New RPs and new resource types require a discussion with the ARM Modeling Review team before merging.

    If you haven't discussed yet:
    Please schedule a meeting at ARM API Modeling Office Hours.

    If ARMModelingSignedOff label was removed by automation:
    This happens when the lease file is not found. Please check with the PM you discussed your design with to confirm if the lease file PR has been merged. In the public repo, lease files reflect immediately after merge. In the private repo (azure-rest-api-specs-pr), lease files typically sync within a few hours, but it can take up to 1-2 business days depending on sync pipeline timing and queue load. Please wait for the sync to complete.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added ARMReview resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 29, 2026

@ravimeda ravimeda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM API Review

Posting findings from automated ARM API review (critic-verified, 2 iterations, converged). See inline comments for findings 3-12. The two issues below concern files not in the PR diff and are posted here.


🔴 Blocking #1 — [NEW] Generated swagger missing

File: specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/kubeInventory/preview/2026-06-15-preview/kubeInventory.jsonnot present at head SHA

Issue: kubeInventory/tspconfig.yaml line 10 declares output-file: "{version-status}/{version}/kubeInventory.json", but no generated swagger is checked in (404 at both kubeInventory/preview/2026-06-15-preview/ and the parent preview/2026-06-15-preview/). ARM TypeSpec projects MUST commit the emitted swagger alongside the .tsp source so AutoRest, SDK generation, and ARM manifest validation can consume it.

Fix: Run tsp compile . in the kubeInventory/ directory and commit the produced kubeInventory.json plus all referenced example files at their final swagger-relative paths.


🔴 Blocking #2 — [NEW] readme.md not updated

File: specification/kubernetesconfiguration/resource-manager/readme.mdnot modified in this PR

Issue: A new API version and a new input file are being added, but the service readme.md has no new tag: block and no updated input-file: list referencing the new kubeInventory.json. The new surface will not be processed by AutoRest or any SDK generation pipeline.

Fix: Add a tag (e.g., package-2026-06-15-preview-kubeinventory) listing the new input file; update the default tag: selector if appropriate.


PR title note: 2026-06-16-preview in the PR title but spec/folder/examples use 2026-06-15-preview. Likely a typo to correct before merge.

@ravimeda ravimeda added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 29, 2026
@bgriddaluru bgriddaluru changed the title Add 2026-06-16-preview API version for Microsoft.KubernetesConfiguration to add KubeInventory and UpgradeAssessment [WIP] Add 2026-06-16-preview API version for Microsoft.KubernetesConfiguration to add KubeInventory and UpgradeAssessment May 29, 2026
@bgriddaluru bgriddaluru changed the title [WIP] Add 2026-06-16-preview API version for Microsoft.KubernetesConfiguration to add KubeInventory and UpgradeAssessment [WIP] Add 2026-06-16-preview API version for Microsoft.KubernetesConfiguration to add KubeInventory May 29, 2026
@bgriddaluru bgriddaluru changed the title Add 2026-06-16-preview API version for Microsoft.KubernetesConfiguration to add KubeInventory and UpgradeAssessment Add 2026-06-15-preview API version for Microsoft.KubernetesConfiguration to add KubeInventory and UpgradeAssessment Jun 9, 2026
@bgriddaluru bgriddaluru changed the title Add 2026-06-15-preview API version for Microsoft.KubernetesConfiguration to add KubeInventory and UpgradeAssessment Add 2026-06-15-preview API version for Microsoft.KubernetesConfiguration to add KubernetesResources and UpgradeAssessments Jun 11, 2026

@dipti-pai dipti-pai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgriddaluru FYI, you will need to update the operations folder to add this new API version. Sharing a link to the comment where this decision was made when the monolithic KubernetesConfiguration service was broken into suite of services model - #31523 (comment)

@github-actions github-actions Bot added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants